Flatten vehicle menus, make appliances menu top level

[irwiss]

Summary

None

Purpose of change

Fixes #24802 - Makes electronics controls top level, and toggling electronics doesn't close menu.

Allows rebinding of vehicle menu keys

Makes appliances menu top level, rather than sub menu of vehicle interact_with; moved 'plug appliance' option inside the appliance menu, and any interact_with items should also appear in menu built by veh_app_interact::populate_app_actions.

Stops closing menu when toggling electronics, remember/forget vehicle position, enable/disable cruise control, camera systems enable/disable and opening/closing doors and curtains.

---

I've wanted to clean up vehicle::interact_with back in #44940 but then got busy IRL so I dropped it, got to complete it now.

There's 2 very similar menus; vehicle examine menu (triggered with e) and controls menu (triggered with ^), they're super similar but slightly different: Controls menu has half baked (closes after every action) top level electronics menu (and electronics sub menu too which doesn't close after every action) but not handbrake or horn. Examine menu has handbrake but not top level electronics. There's more differences but it's just inconsistent; this patch makes both trigger the same (and single) menu.

Describe the solution

Refactoring the stuff in vehicle_use menus is awkward as it uses uilists with enums or int based indexing, which splits every menu item to 2 (or even 3 in case it needs theft check skip) separate places you need to touch.

This patch makes a helper class veh_menu in veh_utils.h/cpp for syntax sugar and wrapping over uilist functionality related to vehicles - registering hotkeys, theft check, part location callback, invalidating map cache and vehicle::refresh() are all called inside of it, it also stores the delegates in std::function so they can be passed around; for example to be used in appliances UI.

This also allows extracting entries from vehicle::interact_with into veh_app_interact::populate_app_actions enabling appliance to be a top level menu.

Trivial menu example can be seen in autopilot commit

After converting menus to use the helper class I merged the use_controls menu into interact_with menu.

Some hotkeys had overlaps, I moved what (in my opinion) is less important to less convenient keys:

• Pull handbrake from h to H
• Activate autoclave from a to C
• Toggle space heater from s to J
• Toggle engine from e to s
• Toggle cruise control from c to nothing
• Added smart controller settings keybind (nothing by default) to allow rebind
• Added hotwire hotkey h (only relevant if vehicle locked, not interfering with headlights toggle)

But they can be rebound by players now so most inconvenience can be resolved in ? menu

Describe alternatives you've considered

Testing

Unfortunately manually tested as it's mostly a UI change;

• e on appliance - appliance menu should appear directly (without vehicle menu first)
• ^ near vehicle controls - menu should appear
• ^ on vehicle controls - should take controls
• ^ on vehicle controls while already in control - should show menu
• e on vehicle controls while already in control - should show menu
• Locked vehicles should display menu on either e or ^ with most choices involving electronics/battery disabled and extra options for hotwiring/triggering alarm ( a bit tricky to test as vehicles that are both locked and have security system intact are rare, I worked around it by making horn action set is_locked = true ).

Remember/forget vehicle position, enable/disable cruise control, electronics toggles (including camera system), closing/opening individual doors/curtains in "Toggle doors" menu should not close the menu but let you continue toggling on/off and seeing the light/vision changes live.

Additional context

Appliances menu made top level instead of transitioning through vehicles examine menu
https://user-images.githubusercontent.com/6560075/189246050-68a448ba-24ea-4de5-9749-a35e3566f6d7.mp4

Vehicle menus don't close when activating electronics and similar options
https://user-images.githubusercontent.com/6560075/189245891-f7038b40-7879-4bd1-a454-b25de2b2169c.mp4

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Toggle autoclave

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.