Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limbify/flagify field immunity #60852

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Sep 8, 2022

Summary

Features "Field immunity changes"

Purpose of change

Fixes #60442 and prepares field immunity for nonstandard limbs.

Describe the solution

Field immunity changes:

  • Instead of trait IDs character flags are checked, meaning effects/bionics/bodyparts now all can allow you to ignore certain fields (Potion of Acid Resistance, anyone?)
  • Instead of bodypart string IDs the environmental protection check evaluates all bodyparts of a given limb type, any one uncovered limb will render you susceptible to the field
  • Added checking for worn item flags worn on a given limb type

Misc changes:

  • The searchlight's dazzling explosion got a lowered field chance but a random AOE
  • Changed all traits immunities to flags, and added the flags to the relevant traits

Describe alternatives you've considered

Just add a flashbang spell effect to the death function, but I was in an overengineering mood.

Testing

Added the flash protection requirement on the sensor bodypart type to dazzling fields, got blinded without a welding mask but kept my sight with it. Changed the bodypart type to arm and got blinded even with a mask.
Gastropod foot still confers immunity to sludge fields.
Activated gas masks confer immunity to toxic clouds.

Additional context

There's a lot of unhardcoding to do in this space, and the field effect definitions still key off of bodypart IDs, but that's a PR for another time.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod Mods: Desert Region Anything relating to the Desert Region mod Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 8, 2022
@Venera3 Venera3 added the Limbs Limbs, mutable limbs, and code related to them. label Sep 8, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 8, 2022
Co-authored-by: Fris0uman <[email protected]>
@github-actions github-actions bot added the <Enhancement / Feature> New features, or enhancements on existing label Sep 9, 2022
@Fris0uman Fris0uman merged commit 4840ee2 into CleverRaven:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. [Markdown] Markdown issues and PRs Mods: Aftershock Anything to do with the Aftershock mod Mods: Desert Region Anything relating to the Desert Region mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being blinded with glare protection by milspec searchlight
3 participants