Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepper_1 NPC background expansion and locked LMOE computer #60737

Merged
merged 21 commits into from
Oct 13, 2022

Conversation

onura46
Copy link
Contributor

@onura46 onura46 commented Sep 4, 2022

Summary

Content "Add a computer and connected NPC dialog to locked LMOE"

Purpose of change

Follow-up to #59515; adds a computer inside the locked LMOE for storytelling context and conversation with the related NPC.

Describe the solution

Follow-up to #59515. This PR is in response to a couple people who have been confused by the locked LMOE from the prepper_1 quest. Since it's pretty unlikely for players to meet this NPC (especially those who don't interact with them), I thought it would be pertinent to imply a little bit of their story in a computer located inside their LMOE. There are also natural dialog options for confronting them about it, depending on which order you discovered the prepper and the LMOE.

The computer in the LMOE shows a conversation between the prepper and the previous owner of the land. It also contains personal documents and conversations showing the prepper is a bit of a conspiracy theorist. At a certain point, it became a little hard to wrap up the conversations without exploring this character's mind a little, so (if you're nice to them) you can chat with them a little bit about the apocalypse, including telling them about Hub 01 and Brigitte, the Bone Seer. I wanted this dialog to be natural and respond to the player's previous adventures.

Another related minor tweak: the Locked LMOE is now a globally unique spawn instead of just unique. This was an oversight of my original PR.

Describe alternatives you've considered

I thought about just leaving the shelter unlocked. However, not only does this kind of ruin the original intent of the mission - reward players who are interacting with and doing quests for an NPC - but I don't think anyone would leave their valuable shelter unlocked if they planned to return to it. Locked shelters should probably realistically be quite common. Anyway, I would bet that the likelihood that players interact with this computer versus the NPC is very high, and it would (at least, in my opinion) make it pretty cool to realize you stumbled upon their secret LMOE and read their secret diary before you even met them.

Testing

Tested on my own compiled version. I went through the dialog trees every way that I could think of.

Additional context

SPOILERS BELOW

Snooping through the Prepper's documents:

ChattingWithComputer

Chatting about the apocalypse with the Prepper after confronting them:

ChattingWithPrepper

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Sep 4, 2022
@onura46 onura46 changed the title Prepper quest fix 2 Add computer to locked LMOE Sep 4, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 4, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 4, 2022
@github-actions github-actions bot added Lore Game lore, in-game communication. Also the Lore tab. BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 4, 2022
@RelMayers
Copy link
Contributor

Lore dump addition sounds bad, also LMOE aren't bunkers, Computer is drain on power which would be bad preparation. I don't see people making their home bunkers for survival showing off their Computers there.

@onura46
Copy link
Contributor Author

onura46 commented Sep 4, 2022

Lore dump addition sounds bad, also LMOE aren't bunkers, Computer is drain on power which would be bad preparation. I don't see people making their home bunkers for survival showing off their Computers there.

I understand what you're saying. Fwiw, this NPC is just as clueless - probably moreso - than the average citizen pre-cataclysm, so you're getting less a lore dump (as in: sound, factual information about what really happened) and instead just another biased view of the confusion before the start date of the game. Read a bit of the dialog that I added and it should become pretty obvious the prepper is not on the right track lmao.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 8, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 8, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 2, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • &A video file starts playing. It's quite low resolution, very shaky, and the sound is somewhat muffled as the cameraperson appears to be filming inside from their car. On screen a man is walking away from the camera towards a nondescript white building with large windows. The glare of the sunlight makes it hard to tell but it looks like… an airport terminal! The man is very far away, wearing an orange safety vest and a hard hat, and he appears to be carrying a laptop bag. You hear the person behind the camera mutter, "I've only ever seen him come and go through that door. No one else in the entire time I've been watching…" The man walks straight into the building, only looking back briefly as he swipes a keycard at the door and enters.
  • &The cameraperson sighs. The view slowly zooms out for a few seconds, but then suddenly jerks to the left. "Ay… hey, look at these motherfuckers!" The camera zooms in on two teenagers next to a car in the parking lot. They're both laughing and shouting very loudly, almost seemingly intoxicated… One kid takes a step back, then kicks in the taillight of the car. The other appears from around the other side of it, dragging their keys along it, scratching up the paint. The boy who was kicking begins violently punching the window with his bare fist. The cameraperson lets out an astonished gasp, "Like New York…" One punch, two punch, and with a third smash his arm goes through the glass! He stares at the other teenager and they both let out a burst of laughter that lasts a little too long. The cameraperson mutters a concerned "Uhhh…" and sets the camera on the seat. The recording abruptly ends.
  • Gov assigns names based off numerological conversions of house numbers. Robert Williamson: 205 W Orchard Avenue. Robert (78) + Williamson (127) = 205. Despite the beautiful weather, he keeps the curtains closed and no one has even visited yet. And he's been here for more than two weeks! I only ever see him when he's coming or going from work. I assume it's work, even if the hours are strange sometimes. Black car, out of state plates, looks brand new. Fed behavior, if you ask me… Is he actually going somewhere or just trying to convince me he's legitimate? Is he on the job when he leaves or on the job when he's here? Further investigation required.
  • robert williamson.txt

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Zireael07
Copy link
Contributor

PR title claims it adds a computer but looking at the checklist and commits reveals there are many other changes... so which is it?

@onura46
Copy link
Contributor Author

onura46 commented Oct 3, 2022

PR title claims it adds a computer but looking at the checklist and commits reveals there are many other changes... so which is it?

It's a work in progress and you could also just read what it adds...

@Zireael07
Copy link
Contributor

Yes, but the title claims it adds a computer, while the rest of the OP and your comments seem to indicate the scope is much much larger. The title should be changed to reflect the contents better

@onura46 onura46 changed the title Add computer to locked LMOE Add computer to locked LMOE and other changes Oct 3, 2022
@onura46
Copy link
Contributor Author

onura46 commented Oct 3, 2022

Yes, but the title claims it adds a computer, while the rest of the OP and your comments seem to indicate the scope is much much larger. The title should be changed to reflect the contents better

It's really not much larger. It's just not a half-assed implementation of an idea.

@onura46 onura46 changed the title Add computer to locked LMOE and other changes Prepper_1 NPC background expansion and locked LMOE computer Oct 3, 2022
@onura46
Copy link
Contributor Author

onura46 commented Oct 3, 2022

And actually, I spent a lot of time today trying to wrap it up and I think it's at a good enough place for open critique. It's going to stay in draft form for a couple days while I do more testing, and run the story/lore-related stuff by longer-standing community members. The title should properly reflect the scope of the PR; it was the last thing I was thinking about until the code was finished tbh.

@onura46 onura46 marked this pull request as ready for review October 5, 2022 21:22
@onura46
Copy link
Contributor Author

onura46 commented Oct 6, 2022

This keeps inheriting the "Lore" label because I mentioned the word in the very first PR related to this NPC. It wasn't super important but now it might be a problem. These PRs are not related to lore (this, #59515, and #59165). If someone with privileges could remove that label, that'd be appreciated! <3

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only trouble we have here now is that this is a really epic story that none of our other backgrounds meet in quality.

I haven't checked the loot in the shelter but even though it's been somewhat looted we should make sure it's a bit better than your average LMOE because of the rarity adn difficulty of getting it.

@I-am-Erk I-am-Erk merged commit 8c69f56 into CleverRaven:master Oct 13, 2022
@onura46 onura46 deleted the prepper-quest-fix-2 branch March 19, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants