fix cables

[Hirmuolio]

Summary

Bugfixes "Fix power cables"

Purpose of change

Fix #60512

Describe the solution

Remove the item in the item use action.

Describe alternatives you've considered

Use "SINGLE_USE" flag.

Testing

Jumper cable is removed after use (vehicle) and works.
Extension cord is removed after use (appliance) and works.

Additional context

[irwiss]

Between #60489 and this cables issue, I think something is broken with how iuse::* return value is used

Returning 1 should already remove the item from inventory, no?

If not then the comment here needs to be updated too (well, it needs to be updated to int regardless but...), and the functions changed to void

Cataclysm-DDA/src/iuse.h

Line 24 in 70905b5

// iuse methods returning a bool indicating whether to consume a charge of the item being used.

[Hirmuolio]

There is a more up to date comment in iuse.cpp https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/iuse.cpp#L493

Seems like that comment in iuse.h is several years out of date.

Both of the problems were fallout from #60039.
The reason for cable problem: It used to be so that if the use action returned >0 (to consume charges) and the tool json was defined to consume 0 charges per use the tool would then be deleted. That weird behavior was removed. Either items need to use the "SINGLE_USE" flag or remove the item in the use action.

[irwiss]

Ah I see, might be worth moving the up to date comment to the header then - IDEs can pick it up for hints as well.

Not sure how anyone will find a comment buried 500 lines down in the middle of unrelated methods