Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folding vehicles duplication #60536

Closed
buffog opened this issue Aug 28, 2022 · 3 comments · Fixed by #60545
Closed

Folding vehicles duplication #60536

buffog opened this issue Aug 28, 2022 · 3 comments · Fixed by #60545
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@buffog
Copy link

buffog commented Aug 28, 2022

Describe the bug

Activating folded vehicle no longer removes it from inventory.

Steps to reproduce

  1. Spawn or otherwise acquire any folding frame
  2. Construct a folding vehicle
  3. Activate the vehicle to unfold it
  4. Vehicle deploys, while its copy stays in inventory/wielded, allowing any number of additional activations.

Expected behavior

Expected not being able to spawn infinite copies of a folding vehicle

Screenshots

No response

Versions and configuration

Version: 70905b5, Android x64, Tiles, English language.
Reproducible with default mods.

Additional context

No response
@buffog buffog added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Aug 28, 2022
@buffog buffog closed this as completed Aug 28, 2022
@buffog buffog reopened this Aug 28, 2022
@irwiss
Copy link
Contributor

irwiss commented Aug 28, 2022 •
edited
Loading

Likely needs same treatment as #60512

#60516

@buffog
Copy link
Author

buffog commented Aug 28, 2022 •
edited
Loading

Tents also duplicate.
As does inflatable boat on first activation. Not sure if it uses same mechanics as folding vehicles.

@irwiss
Copy link
Contributor

irwiss commented Aug 28, 2022 •
edited
Loading

Not sure if it uses same mechanics as folding vehicles

It does, all folding vehicles now use the same code paths after 646fa4d

Tents have separate iuse

@irwiss irwiss mentioned this issue Aug 29, 2022
Merged
@NetSysFire NetSysFire added <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplication of folding vehicles and tent in iuse irwiss/Cataclysm-DDA
3 participants
@irwiss @buffog @NetSysFire