Prevent vehicles with only PROTRUSION left #60458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Hirmuolio
pushed a commit
to Hirmuolio/Cataclysm-DDA
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #40427
Fixes part of #46594 (the forklift exploit part, but not running engine for hydraulics part)
Describe the solution
Check we are not left with PROTRUSION as the only "structural" part
Comment near by states
* If size = 1, it's one protruding part (i.e., bicycle wheel), so OK, but apparently it's not OK after all, as it allows vehicles that have a supposedly "structural" part but it's leaving just a standalone ram / wing mirror / forklift "vehicle"Describe alternatives you've considered
I'm not sure why wing mirrors and forklifts have "structure" for location, this also prevents walking on that tile not just for rams, even though it's either a small mirror part or it can go under stuff.
But checking for PROTRUSION specifically is likely the smallest change to close the loopholes.
Testing
Reproduction steps in #40427 should not work on step 3
Reproduction steps in #46594 should not work on step 4
Additional context