Add attack vectors to martialarts_fictional.json(Five Deadly Venoms + Bionic Combatives) #60138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
TheShadowFerret
changed the title
github-actions
bot
added
json-styled
Hirmuolio
pushed a commit
to Hirmuolio/Cataclysm-DDA
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Five Deadly Venoms and Bionic Combatives have attack vectors"
Purpose of change
The Five Deadly Venoms and Biojutsu's attack techniques don't function due to a lack of an attack vector.
Fixes #60122.
Describe the solution
Add "appropriate" attack vector
*See additional context
Describe alternatives you've considered
Besides the FINGERS bug, a hand vector for Lizard Wall Dive.
Testing
Attack a debug monster while next to a wall(Lizard Style) using every style, see every non-disarm technique trigger. Spawn NPCs, disarm them with Bionic Combatives & Centipede Kung Fu.
Additional context
Ping @Hymore246 as maintainer of MythMA
FINGERS is supposed to be a valid attack vector per #53934 & would be used for the spearhand strike, but it doesn't register so I had to use HAND instead.