Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet repair fix #59954

Merged
merged 4 commits into from
Aug 7, 2022
Merged

Conversation

Karol1223
Copy link
Contributor

Summary

Bugfixes "Adds repair-like tags to ties and wallets"

Purpose of change

Wallets and ties had no repair-like tags and this combined with them being uncraftable made them default to require tailoring 10 to repair which is absurd. Also, fixes #59769

Describe the solution

Added repairs-like tags to most wallets and all the ties. Regular wallet repairs like a backpack, all the leather wallets repair like a leather belt and all the ties repair like a t-shirt. Also added a no-repair flag for the duct tape wallet.

Describe alternatives you've considered

I initially tried to make duct tape wallets repairable with duct tape using the newly added repairs-with tag but that doesn't work since duct tape is not a material.

Testing

Seems to work fine. Testing revealed that the master plan to make duct tape wallets repair with duct tape isn't possible currently, though.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 6, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit 8067861 into CleverRaven:master Aug 7, 2022
@Karol1223 Karol1223 deleted the wallet-repair-fix branch November 3, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ties and stylish wallet have too high damage chance when repairing compared to other more complex clothing
2 participants