Adjust Weight/Volume of Ballistic Armor Plates

[ANickelN]

Summary

Balance "Adjust Weight/Volume of Ballistic Armor Plates"

Purpose of change

To adjust the weight and/or volume of some of the armor plates present in the game.
The makeshift plates added in #57881 were really, really light and small for what they are supposed to be so they got adjusted as well.

The time to put in plates and remove them was also changed, as 2 seconds for inserting or removing an armor plate is ridiculous. 8 seconds is the new time to insert considering they have to be secured as well as forced in.

Describe the solution

Go to manufacturer's sites in order to get information on commercially available plates and input that.

Describe alternatives you've considered

Do nothing.

Testing

Only minor testing done, but the plates seem to be correctly sized and able to fit in the carriers.

[ANickelN]

Finished here, I'd like to go in and change some more stuff but I will leave it for a later PR.

[bombasticSlacks]

On top of what's been posted here you also missed items that have ablative pockets. If these changes are merged all of those will break unless also updated.

[ANickelN]

Not sure why it is failing at this point, let me know if it is something I did or unrelated.

[anothersimulacrum]

The item density tests (which matter now) are failing: https://github.com/CleverRaven/Cataclysm-DDA/runs/7373858781?check_suite_focus=true#step:16:208

[bombasticSlacks]

Yeah it looks like your scrap plates are per volume still too heavy. Im good with all these changes generally however 👍

[ANickelN]

My calculations for the scrap ESAPI plate was:
"30cm x 25cm x 0.2cm" = 150ml of space
150 ml = 150 cubic centimeters

Steel has a density of 8g/cm3, multiply 150cm3 * 8g and you get 1,200g. The plates are currently weighted at 1181g (very slightly lower because I used 7.87g/cm3 as my reference). Am I making a mistake here or is there an error in the test? How are they too heavy?

[anothersimulacrum]

It is because nylon is also listed as a material they are made of.

[ANickelN]

It is because nylon is also listed as a material they are made of.

There is no nylon in either of the scrap metal recipes. There is cotton though, should I make it a proportion then?
Ex: "material": [ { "type": "budget_steel", "portion": 15 }, { "type": "cotton", "portion": 1 } ]

[anothersimulacrum]

Yeah, something like that would work. Or outright removal: #59333

[ANickelN]

Again a failure, but pretty sure it isn't my fault this time. Looked in the error log and couldn't even figure out what failed. Basic build passed.

[anothersimulacrum]

Not your fault: https://github.com/CleverRaven/Cataclysm-DDA/runs/7400054770?check_suite_focus=true#step:16:460
Not your fault: https://github.com/CleverRaven/Cataclysm-DDA/runs/7400054770?check_suite_focus=true#step:10:210