Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvised ballistic plates in the style of scrap metal armor #57881

Merged

Conversation

delarifert
Copy link
Contributor

Summary

Content "Adds improvised metal ballistic plates in the style of scrap armor"

Purpose of change

This fixes #49477, or at least implements the content it requests.

Besides implementing a good idea, I'm doing this for exposure to the armor system and the community, to hopefully work on other things too.

Describe the solution

Adds two recipes, scrap ESAPI and scrap ESBI plates, to represent taking a hunk of metal and stuffing it in a plate carrier.

Describe alternatives you've considered

I briefly considered not doing this.

Testing

I've spawned the new scrap plates in game and checked their values, both stats and in combat using a US ballistic vest. I've also tried both the added recipes.

Additional context

This was OK'd in Discord, and I'm new. Please let me know if I need to do anything else or messed up, thanks.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions labels May 23, 2022
Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to lint your files. Take both the files you have changed and copy the whole files text into https://dev.narc.ro/cataclysm/format.html. It will make them look pretty (and is required for merging) then you can just copy the result back into the file.

data/json/items/armor/ballistic_armor.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 24, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 24, 2022
@bombasticSlacks bombasticSlacks merged commit 2bdeed8 into CleverRaven:master May 24, 2022
@delarifert delarifert deleted the 49477-scrap-ballistic-plates branch May 31, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add makeshift/metalplate ESAPI vest
2 participants