Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete necropolis #58842

Merged
merged 19 commits into from
Jul 1, 2022
Merged

Obsolete necropolis #58842

merged 19 commits into from
Jul 1, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Jun 30, 2022

Summary

Content "Obsolete necropolis"

Purpose of change

Close #57030 , remove #52523 from stable tracker, make Erk sad

Describe the solution

Moves necropolis mapgen content to obsolete, changes "overmap_special" entry so it does not fire, same for OMT. Changes end of Old Guard questline to no longer refer to this content.

Describe alternatives you've considered

Let someone else do this, wait for someone to volunteer to maintain it as a mod

Testing

Game loads no errors, jumping around on two maps and revealing, no necropolis spawned.

Additional context

Builds on work in #57028

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jun 30, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 30, 2022
@github-actions github-actions bot added the NPC / Factions NPCs, AI, Speech, Factions, Ownership label Jun 30, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 30, 2022
@LyleSY LyleSY marked this pull request as ready for review July 1, 2022 00:37
@Rivet-the-Zombie Rivet-the-Zombie merged commit 679fd9f into CleverRaven:master Jul 1, 2022
@LyleSY LyleSY deleted the obsoleteNecropolis branch July 1, 2022 11:01
@a-chancey
Copy link
Contributor

I know better than to comment on a merged/closed PR, but Erk is not the only one who is saddened by this :(

maybe I’ll get some time to get it updated after stable drops and it can come back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the Necropolis to a mod for now, and rework it in the future
3 participants