-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete necropolis #58842
Merged
Rivet-the-Zombie
merged 19 commits into
CleverRaven:master
from
LyleSY:obsoleteNecropolis
Jul 1, 2022
Merged
Obsolete necropolis #58842
Rivet-the-Zombie
merged 19 commits into
CleverRaven:master
from
LyleSY:obsoleteNecropolis
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apgen/necropolis/necropolis.json
…son/obsoletion/overmap/overmap_terrain/overmap_terrain_necropolis.json
…/mapgen_palettes/necropolis_a.json
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
labels
Jun 30, 2022
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jun 30, 2022
…bsoletion/npcs/necropolis/NPC_Old_Guard_Captain.json
github-actions
bot
added
the
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
label
Jun 30, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 30, 2022
I know better than to comment on a merged/closed PR, but Erk is not the only one who is saddened by this :( maybe I’ll get some time to get it updated after stable drops and it can come back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Obsolete necropolis"
Purpose of change
Close #57030 , remove #52523 from stable tracker, make Erk sad
Describe the solution
Moves necropolis mapgen content to obsolete, changes "overmap_special" entry so it does not fire, same for OMT. Changes end of Old Guard questline to no longer refer to this content.
Describe alternatives you've considered
Let someone else do this, wait for someone to volunteer to maintain it as a mod
Testing
Game loads no errors, jumping around on two maps and revealing, no necropolis spawned.
Additional context
Builds on work in #57028