Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent necropolis from spawning #57028

Closed
wants to merge 2 commits into from

Conversation

Inglonias
Copy link
Contributor

Summary

Content "Disable the necropolis"

Purpose of change

Closes #44336 and #52523 by invalidating them

Describe the solution

Set the occurrences for the necropolis to zero.

Describe alternatives you've considered

Not being a smartass about this and actually taking a stab at fixing the thing, but... it's big and I don't wanna.

Testing

N/A

Additional context

This feels like a bit of a smartass solution to the issues mentioned above. Sort of "throwing the baby out with the bathwater", I suppose. But to be blunt, the necropolis as it stands is huge and unwieldy. Mapgen technology has advanced quite a bit since this special was built. We have things like nested mapgen now. This special is aching for an overhaul, but until someone steps up to the plate, the structure we have is outdated, broken, and feels somewhat out of place considering lore developments.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Apr 22, 2022
@Inglonias
Copy link
Contributor Author

I want to be clear that I don't dislike the concept of the necropolis. I just don't think that in its current form, it should exist in an un-modded game.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 22, 2022
@Maleclypse Maleclypse added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 22, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 22, 2022
@anothersimulacrum
Copy link
Member

anothersimulacrum commented Apr 22, 2022

I don't think this is the right solution, it prevents accessing the second half of the old gaurd quest line. Not that that is particularly great, but it could be made at least a little cleaner. If we're going to remove this, we should just commit to it and delete it, and redirect the content that it has related to it.

@PatrikLundell
Copy link
Contributor

I believe there's a connection to #57030 here.

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this can't be done in these steps... The missions need to be disabled first, then the spawning. And all these things should be moved to a mod so people can still explore the necropolis.

@Inglonias
Copy link
Contributor Author

Based on the feedback I'm seeing, this is probably a bad solution to this issue, so I'll close this for now. If I get bored, I'll work on the changes that erk mentioned, but as I type this, I'm feeling a little lazy for that.

@Inglonias Inglonias closed this Apr 23, 2022
@Inglonias Inglonias deleted the obsolete_necropolis branch May 16, 2022 18:04
@LyleSY LyleSY mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No items spawning in upper floor of the Vault
5 participants