Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate c-style math functions to C++ cmath counterparts #58766

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

The real purpose is to test if LGTM static analysis works after the change in #58246. If everything is okay, LGTM should report that this pull request solves several warnings.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 27, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 27, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request fixes 7 alerts when merging 6cc660f into 31319f8 - view on LGTM.com

fixed alerts:

  • 7 for Use of c-style math functions

@ZhilkinSerg ZhilkinSerg merged commit b1d5318 into CleverRaven:master Jun 27, 2022
@BrettDong BrettDong deleted the cmath branch June 28, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants