Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
LGTM C++ analysis has been timing out for months, resulting in a red X mark in all C++ pull requests. This does not look good.
Describe the solution
After doing a few test builds with different configurations, I found that excluding the tests from the analysis ensures it can complete in around two hours and a half. Including the tests adds 1.5 hours of build time and analysis time, and brings the total time to 4 hours and timeouts. So this pull request instructs LGTM to only analyze the main game and exclude the tests.
Describe alternatives you've considered
Testing
LGTM C++ analysis succeeded, finishing within two hours: https://lgtm.com/logs/f4c70305b114ec88fac7a40b4b6277bb6192150e/lang:cpp
Additional context
LGTM C++ analysis may still fail on this pull request, because building the
master
branch still times out. But building the merge commit should succeed.