Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing materials recipes and rebalance of material costs #57791

Merged

Conversation

stubkan
Copy link
Contributor

@stubkan stubkan commented May 18, 2022

Summary

Balance "Added missing materials recipes and rebalance of material costs"

Fixes #54962
Fixes #52882

Purpose of change

There are items that have no use (synth fabric sheet and nomex sheets) that you can acquire from disassembly or loot and they sit uselessly in your cargo. They cannot be converted into anything at this stage.

Also kevlar is way overpriced, disassembly of broken vests that cost very little can net you parts that sell for hundreds of dollars of profit.

image

Material costs are a little mixed up, not really ranked in order properly.

Some simple recipes are taking obscene amounts of time to do. Creating patchwork sheets that take seconds in some recipes, take 270 minutes in others. Reduced the times for some, increased for others.

Also unrelated to materials but throwing in there anyway, a loop of rope that you can construct early game to hold large items up to 80kg only requires a short string, despite the description saying its a rope.

Describe the solution

Reduced obscene times for creating material sheets from 270min to 60min

Added recipe to convert unusable nomex and synth fabric sheets that you can get into actual usable nomex and synth fabric patches. You can repair clothing with these. You make a kevlar layered patch with 16 sheets. Nomex requires 8 sheets, synth fabric requires 4.

Adjusted kevlar spare parts prices so they arent priced exploitively.

Adjusted pricing of spare part materials to scale with other similar items.

Fixed loop of rope recipe using a short string to actually using a short rope.

Describe alternatives you've considered

Testing

Additional context

New pricing for materials

scrap sheet patch rigid hide
cotton 5 10 20
leather 5 25 500
synth 5 20 40
neoprene 5 35 60
nomex 8 40 80
kevlar 10 50 150 250
faux fur 5 20 50
lycra 5 20 50
felt 5 20 50

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 18, 2022
@toweroglass
Copy link

a) both those sheets have recipes. But I understand it's probably hyperbole
b) you can cut the sheets into patches if I'm not mistaken.
c) as I type this I realize I'm probably being pedantic and making it more obvious you can get patches from sheets wouldn't be a bad thing.

@stubkan
Copy link
Contributor Author

stubkan commented May 19, 2022

a) both those sheets have recipes. But I understand it's probably hyperbole b) you can cut the sheets into patches if I'm not mistaken. c) as I type this I realize I'm probably being pedantic and making it more obvious you can get patches from sheets wouldn't be a bad thing.

I assume you are talking about nomex and synth fabric patches?

If recipes exist please point them out. I saw none ingame, none in materials recipe json, hitchhikers guide shows none.

I added these mainly because there is no upgrade/disassemble path to use these 2 items that you can easily get a lot of sheets of - and they are mostly unusable in the sheet state.

Referenced in issue #54962

@toweroglass
Copy link

a) both those sheets have recipes. But I understand it's probably hyperbole b) you can cut the sheets into patches if I'm not mistaken. c) as I type this I realize I'm probably being pedantic and making it more obvious you can get patches from sheets wouldn't be a bad thing.

I assume you are talking about nomex and synth fabric patches?

If recipes exist please point them out. I saw none ingame, none in materials recipe json, hitchhikers guide shows none.

I added these mainly because there is no upgrade/disassemble path to use these 2 items that you can easily get a lot of sheets of - and they are mostly unusable in the sheet state.

Referenced in issue #54962

patches are for repairing clothes they don't need to have recipes they are used in. sheets as i understand them are factory produced rolls of fabric which are more suitable to making large pieces of clothing. You can drop them on the ground and cut them into patches. because patches are 50g and sheets are 3g.

that said, you might be looking at stable. stable does not have recipes that use synthetic sheets.
Synthetic fabric sheets have countless uses, even not counting redundancies. Nomex sheets have been used in flame resistant clothing for quite a while.

@toweroglass
Copy link

also as i noted in the issue i posted after reading this PR when i looked at HHG, patches of every kind were added to almost all cloth recipes with really bad usage calculations.

@stubkan
Copy link
Contributor Author

stubkan commented May 19, 2022

patches are for repairing clothes they don't need to have recipes they are used in. sheets as i understand them are factory produced rolls of fabric which are more suitable to making large pieces of clothing. You can drop them on the ground and cut them into patches. because patches are 50g and sheets are 3g.

You cant cut up sheets into patches - it is the other way around - I know the description says sheets and you get bolts of sheets from the factory... but in this game sheets is the halfway point between a scrap and a patch. a sheet is much smaller than a patch. Like you said, a sheet is 3g so cutting that up into smaller pieces of 50g?

The issue isnt that theyre not used in any recipes - the issue is that there are no recipes for getting them. You NEED patches to repair clothes. All the other material types have a sheet to patch recipe, but these 2 don't.

@toweroglass
Copy link

You cant cut up sheets into patches - it is the other way around - I know the description says sheets and you get bolts of sheets from the factory... but in this game sheets is the halfway point between a scrap and a patch. a sheet is much smaller than a patch. Like you said, a sheet is 3g so cutting that up into smaller pieces of 50g?

you drop the full bolt of "sheet" on the ground and cut it up. same way to salvage any material from cutting. drop 100s of "sheets" on the ground and try cutting them. you have patches. It's in the game but I can see how a proper recipe might make it more clear/predictable.

The issue isnt that theyre not used in any recipes - the issue is that there are no recipes for getting them. You NEED patches to repair clothes. All the other material types have a sheet to patch recipe, but these 2 don't.

I'm sorry, but I'm not following. The only direct sheet -> patch recipe i see is for neoprene. but I think i see the benefit of it.

@stubkan
Copy link
Contributor Author

stubkan commented May 23, 2022

I might do another PR to clean up the mess of scrap-sheet-patch and make it clearer for all materials then

@kevingranade kevingranade merged commit 53eefd0 into CleverRaven:master Jun 2, 2022
@remuluson2
Copy link
Contributor

Congrats. You managed to fix this thing before 2 people that said they will rework tailoring system did.

tornikeo pushed a commit to tornikeo/Cataclysm-DDA that referenced this pull request Jun 2, 2022
…erRaven#57791)

* Added missing recipes and rebalance of materials

* Increased material requirements for creating nomex and synth fabric patches
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
…erRaven#57791)

* Added missing recipes and rebalance of materials

* Increased material requirements for creating nomex and synth fabric patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sheets of materials won't be used to repair items Synthetic Fabric Sheets missing recipe
4 participants