Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets of materials won't be used to repair items #54962

Closed
remuluson2 opened this issue Jan 31, 2022 · 10 comments · Fixed by #57791
Closed

Sheets of materials won't be used to repair items #54962

remuluson2 opened this issue Jan 31, 2022 · 10 comments · Fixed by #57791
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling

Comments

@remuluson2
Copy link
Contributor

remuluson2 commented Jan 31, 2022

Describe the bug

You cannot use synthetic sheets, cotton sheets ect. to repair items.

Steps to reproduce

  1. Get a damaged clothing item( for example MOLLE pack)
  2. Get materials needed for repair and tools.
  3. It will refuse to repair the item due to lack of materialls

Expected behavior

I expected the sheets of synthetic fabric and cotton sheets to be usable as materials for repair.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 7684355 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth]
    ]

Additional context

On additional note, sheets when spawned in look like they are containing items equal to the amount of sheets.
When picking them up they drop to the floor in "correct" form

@coyo7e
Copy link

coyo7e commented Jan 31, 2022

I ran into this issue the other day after looting a tailoring basement and putting several thousand sheets of every kind of material (except leather patches, I never find more than a dozen or so pieces of leather in those basements whether it be in a house, mansion, or clothing store) into a pile. Seems specific to certain types of fabric - ie synthetic fabric comes to mind.

I solved the issue by just ignoring repairs for that type of item, sadly.

@LeahLuong
Copy link

This looks like a downstream effect of #54308 or #54843. It may be this problem is already known & actively being worked on.

@a-chancey @mqrause What do you think??

@a-chancey
Copy link
Contributor

Ok just updated. Seems to be related to synthetic fabric specifically. I could cut up a backpack and get “synthetic fabric” to repair other synthetic items, but my “synthetic fabric sheets” don’t work for repairs and can’t be cut up to make the smaller pieces. Fabrics are a mess, which is why I’m working on them so much right now. I’ll jump on those either tonight or in the morning if I get a chance.

@a-chancey
Copy link
Contributor

Actually, upon further investigation, synthetic fabric (item id "nylon") doesn't appear to spawn anywhere. It is only available by deconstructing or butchering specific items.

I'll see what I can figure out later

@coyo7e
Copy link

coyo7e commented Feb 1, 2022

Actually, upon further investigation, synthetic fabric (item id "nylon") doesn't appear to spawn anywhere. It is only available by deconstructing or butchering specific items.

I'll see what I can figure out later

That may not be totally true, because I know for a fact I haven't cut up anything made of synthetic fabric sheets and I have hundreds in my car right now, which I looted from a tailor basement in a mansion. FWIW it was the mansion variant with the "panic room" on the ground floor. It had zero or nearly no leather patches in it though.

Possibly another one of those "the sheets show up but not clothing parts" type things? I seem to recall that was a issue temporarily with cotton clothing parts vs cotton sheets recently, where suddenly some recipes wanted one but not the other..?

image

@a-chancey
Copy link
Contributor

a-chancey commented Feb 1, 2022

Those are synthetic fabric sheets. It’s a different item.

edit: that sounds rude, sorry about that.

The item used to repair synthetic material is called synthetic fabric. The item you have is synthetic fabric sheets

for some reason, synthetic fabric is ONLY available ad a deconstruction or butchering result

This confusing nomenclature is part of why I’m overhauling tailoring currently.

@coyo7e
Copy link

coyo7e commented Feb 1, 2022

tbh I don't know why it was decided to have so many subcategories of basic materials like this anyway lol

@a-chancey
Copy link
Contributor

tbh I don't know why it was decided to have so many subcategories of basic materials like this anyway lol

Yeah sorry I edited my comment as it came off as rude.

I’m working on standardizing the fabrics so we’ll have 12”x24” “commercially” manufactured sheets, the crafted equivalent patchwork sheets, each break down to 2 patchwork clothing parts. In turn, those break down to 4 6”x6” patches each (8 per sheet). Scraps are remnants to be broken down for thread or discarded as waste.

Currently there’s NO size standard, so I did a bunch of research and found average fabric bolt sizes, measured thicknesses and found averages of each of the fabric types. There’s a few exceptions - Kevlar and leather/fur, only because of how pelts vary so much and Kevlar can’t really be patched, it has to be replaced

@coyo7e
Copy link

coyo7e commented Feb 1, 2022

tbh I don't know why it was decided to have so many subcategories of basic materials like this anyway lol

No worries (but I do appreciate the clarification), you mentioned the sheets in the OP so I was looking for them to begin with, which leads into the rabbit-hole of subcategories and figuring out which is what.

I sew a lot IRL and having these tiny patches of fabric/etc is a natural thing but they're generally only used in like quilting and making bias tape and similar stuff in any case, and are useless unless you are making very small projects or specifically want your garment/project to be particolored etc. Having them be required for repairs makes sense in the theory of "I have a small tear in this garment and don't care what it looks like, so I need a small square of fabric to back the stitching work up and reinforce that area" but it really does add a ton of gameplay complexity especially for people who don't do that type of thing a lot IRL, and there are other issues within the UI for it which I'd like t move to a discussion thread some day once I am more comfortable diving into the code for stuff (repair "quality" for instance, which was added to vehicle parts and probably ought to expand to many types but not all types of items, eventually, because patches end up tearing around the edges of the area patched, blades that get badly dinged can be sharpened but get brittle eventually from losing large portion of their intended weight and volume over time, etc, so eventually you end up with a item that's more patch than fabric, or so thin and brittle it is used for something else after a while, whereas with a dinged-up rebar, you just bang it back to shape and move on and ignore the fact it's ugly.. My dad sharpened my set of knives one time a while back as a favor, but he also ran all my STEAK KNIVES through the sharpener and wore off the serration so they became really nice, dangerous looking butter knives!)

I made a ton of shopping bags for xmas a while back and ended up having to piecemeal a lot of parts like the handles, from leftover patches of fabric for instance, but those parts were used as "filler" and not the mats to create them until I ran out of the initial desired, uniform materials and I began to quilt them together in creative ways.. Using them creatively and carefully made it look cool and on-purpose but really, I was just using up loose ends and leftovers of fabric I had lying around once I ran out of bolts of fabric. https://i.imgur.com/C9i6HPD.jpeg

@a-chancey
Copy link
Contributor

Yeah, after discussing it on discord this morning, i'm considering cutting out the patchwork clothing parts and just assuming the clothes get cut down to patches to essentially quilt together. Gonna update the main tailoring issue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants