Allow migration of charges to an equivalent amount of single items #54843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Allow migration of charges to an equivalent amount of single items"
Purpose of change
Fixes #54376
Describe the solution
Put
charges - 1
items of the same itype in the migration pocket of the item.Migration pocket handling isn't ideal since it only unloads items on the player and not on the map and always drops stuff to the ground instead of (trying to) put it in the location the main item is in.
Describe alternatives you've considered
Doing it by default for all items that shouldn't be
count_by_charges
and aren't on the charge removal blacklist, but that might lead to unexpected results. That can still be done later when it's relevant.Testing
Tested migrating the itype
leather
by changing its type toGENERIC
and adding it to the list.Additional context
Sorry for stealing this from the person who was working on it, but I got annoyed by items with charges and this is an important step to remove that.