Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow migration of charges to an equivalent amount of single items #54843

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Jan 27, 2022

Summary

Infrastructure "Allow migration of charges to an equivalent amount of single items"

Purpose of change

Fixes #54376

Describe the solution

Put charges - 1 items of the same itype in the migration pocket of the item.
Migration pocket handling isn't ideal since it only unloads items on the player and not on the map and always drops stuff to the ground instead of (trying to) put it in the location the main item is in.

Describe alternatives you've considered

Doing it by default for all items that shouldn't be count_by_charges and aren't on the charge removal blacklist, but that might lead to unexpected results. That can still be done later when it's relevant.

Testing

Tested migrating the itype leather by changing its type to GENERIC and adding it to the list.

Additional context

Sorry for stealing this from the person who was working on it, but I got annoyed by items with charges and this is an important step to remove that.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 27, 2022
@NetSysFire NetSysFire added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jan 27, 2022
@Maleclypse
Copy link
Member

The hero GitHub deserves.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 27, 2022
@kevingranade kevingranade merged commit 6f14fa6 into CleverRaven:master Jan 28, 2022
@mqrause mqrause deleted the charge_migration branch January 28, 2022 06:08
@a-chancey a-chancey mentioned this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration support to convert charges to copies
4 participants