Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tropicataclysm and additional labels #56719

Merged
merged 12 commits into from
Apr 18, 2022
Merged

Tropicataclysm and additional labels #56719

merged 12 commits into from
Apr 18, 2022

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

More utility for the labelbot!

Describe the solution

Adds more labels to triagebot

Describe alternatives you've considered

None

Testing

NA

Additional context

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 10, 2022
@Maleclypse
Copy link
Member Author

@casswedson I've added a couple items that look like - "src/weather*.*" with the asterisk inside the filename as well. I figure that will likely work but I wanted to confirm with you before it's merged.

@Maleclypse
Copy link
Member Author

@NetSysFire Let me know if I've got the new TropiCataclysm right in labeler and for label itself. Thanks!

casswedson
casswedson reviewed Apr 10, 2022
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
casswedson
casswedson reviewed Apr 10, 2022
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@NetSysFire
Copy link
Member

@Maleclypse Looks good to me

Maleclypse and others added 2 commits April 9, 2022 23:15
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2022
Maleclypse and others added 2 commits April 9, 2022 23:16
@NetSysFire
Copy link
Member

Could you add an autolabel entry to label stuff with the markdown label when the file extension is .md?

@Maleclypse
Copy link
Member Author

Could you add an autolabel entry to label stuff with the markdown label when the file extension is .md?

Sure thing.

@NetSysFire
Copy link
Member

Seeing https://github.com/CleverRaven/Cataclysm-DDA/pull/56767/files, an autolabel entry for the armor/clothing tag for files in that dir (also similar locations) might also be nice.

@NetSysFire
Copy link
Member

To drop even more recent PRs here, https://github.com/CleverRaven/Cataclysm-DDA/pull/56777/files, src/inventory_ui.cpp could be reliably classified as "Info /User Interface"

@Maleclypse
Copy link
Member Author

@casswedson do I need both or just the second?

- "**/ui/**/*"
  - "**/ui**/*"

casswedson
casswedson reviewed Apr 14, 2022
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@dseguin dseguin merged commit 7fc7012 into CleverRaven:master Apr 18, 2022
@Maleclypse Maleclypse deleted the Tropicataclysm-Labeler branch September 24, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casswedson casswedson casswedson left review comments

@dseguin dseguin dseguin approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Maleclypse @NetSysFire @dseguin @casswedson