Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete outdated spell check comment when new commits are pushed in a pull request #56453

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Although there is a mechanism to prevent spell checker from posting duplicate comments in a pull request, it can still create excessive amount of comments when the sentences containing the typos are updated in subsequent commit pushes, but typos themselves still exist, like in #56413. It would look cleaner if previous outdated spell check comments are automatically deleted when posting a new one.

Describe the solution

When spell check completes,

  1. If an exact same spell check comment already existed, just do nothing and exit the workflow
  2. Remove previous spell check comments
  3. Post the new spell check comment

Describe alternatives you've considered

Testing

Not tested.

Additional context

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 29, 2022
@ZhilkinSerg ZhilkinSerg merged commit 646c720 into master Mar 29, 2022
@BrettDong BrettDong deleted the spell-checker-delete-comment branch April 2, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants