-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TropiCataclysm: tropical fishes #56413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added some tropical fishes
added fishes to wilderness spawn
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 28, 2022
syntax fixes
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 28, 2022
BrettDong
reviewed
Mar 28, 2022
BrettDong
reviewed
Mar 28, 2022
BrettDong
reviewed
Mar 28, 2022
BrettDong
reviewed
Mar 28, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Mar 28, 2022
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Drew4484
added a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
Apr 4, 2022
This reverts commit d1cc9f4.
Maleclypse
added
the
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
label
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Adds some tropical fishes"
Purpose of change
Small patch adding some extra tropical fishes to the region.
Describe the solution
-added lungfish
-added electric eel
-added pacu
-added tambaqui
-added piranha
-added arowana
-added arapaima
Describe alternatives you've considered
We have enough fish in the game
Testing
Added the new fishes to river lists. found them while exploring the map
Additional context
There may be more fishes in the future but so far these are the only ones i could think of. Piranhas may be a bit OP