Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete Graphical Overmap mods #56347

Merged
merged 2 commits into from
Mar 27, 2022
Merged

obsolete Graphical Overmap mods #56347

merged 2 commits into from
Mar 27, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Mar 25, 2022

Summary

Mods "obsolete Graphical Overmap mods"

Purpose of change

Quality management, don't waste dev time on code that isn't working

Describe the solution

Adds or changes one line of JSON to obsolete two mods, reviving effort from #49714

Describe alternatives you've considered

Wait for a hero

Testing

N/A, simple JSON change

Additional context

Part of the beautiful and mysterious Abandoned but Desired PRs project

@LyleSY LyleSY added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Mar 25, 2022
@LyleSY LyleSY marked this pull request as ready for review March 25, 2022 22:02
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 25, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 25, 2022
@kevingranade kevingranade merged commit dcde9cd into master Mar 27, 2022
@kevingranade kevingranade deleted the LyleSY-patch-1 branch March 27, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
Development

Successfully merging this pull request may close these issues.

2 participants