Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete old Graphical Overmap mods #49714

Closed
wants to merge 1 commit into from
Closed

Obsolete old Graphical Overmap mods #49714

wants to merge 1 commit into from

Conversation

Mom-Bun
Copy link
Contributor

@Mom-Bun Mom-Bun commented Jul 7, 2021

Summary

Mods "Obsolete old Graphical Overmap mods"

Purpose of change

With #43203 finally merged, there is now a proper graphical overmap in game for tilesets to use. Which means these old mods can finally be obsoleted, and probably for the best as players enabling them could risk causing issues.

Describe the solution

Obsoleted both of them

Describe alternatives you've considered

Potentially waiting until the graphical overmap was more filled out?

Testing

N/A, simple line change and obsoleting an old mod. Shouldn't cause any real issues.

Additional context

Thanks for the new graphical overmap KorGgent!

@anothersimulacrum anothersimulacrum added the Mods Issues related to mods or modding label Jul 7, 2021
@kevingranade kevingranade marked this pull request as draft July 7, 2021 19:29
@kevingranade
Copy link
Member

We're not feature complete enough to fire this off just yet, but yes it does need to happen.

@Theawesomeboophis
Copy link
Contributor

May I have permission to fork Graphical Overmap mods into a third-party repository for anyone who prefers them over new graphical overmap? ( Asking first as I would hate to violate the copyright).

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Jul 10, 2021

As long as you attribute correctly, and continue to distribute under CC-BY-SA 3.0, there is nothing problematic there.

@Theawesomeboophis
Copy link
Contributor

As long as you attribute correctly, and continue to distribute under CC-BY-SA 3.0, there is nothing problematic there.

Okay, I know Larwck made the mod, is there a list of other contributors?

@Theawesomeboophis
Copy link
Contributor

I Looked at Commit History and have made a list of contributors I've seen so far:
Larwck/Larwick
Nyphx
Night-Pryanik
Anothersimulacrum
ZhilkinSerg
Lamandus
ralreegorganon
Kilvoctu
klorpa
Qrox
Does this list look complete or are there some I've missed?

@Theawesomeboophis
Copy link
Contributor

Theawesomeboophis commented Jul 10, 2021

Contributors.txt
This is the file, If I have not attributed properly or anything is wrong, please notify me.
Side Note: where are the symbols located in files, as I do plan on maintenance and stuff, and it would be really useful to know how to contribute.

@stale
Copy link

stale bot commented Aug 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 10, 2021
@actual-nh actual-nh added (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Bugfix> This is a fix for a bug (or closes open issue) SDL: Tiles / Sound Tiles visual interface and sounds. and removed stale Closed for lack of activity, but still valid. labels Aug 10, 2021
@I-am-Erk
Copy link
Member

Are you interested in finishing this mombun?

@Night-Pryanik
Copy link
Contributor

@Mom-Bun are you planning to finish this?

@ZhilkinSerg
Copy link
Contributor

May I have permission to fork Graphical Overmap mods into a third-party repository for anyone who prefers them over new graphical overmap? ( Asking first as I would hate to violate the copyright).

It might have sense to rework this into an overmap tileset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mods Issues related to mods or modding (P5 - Long-term) Long-term WIP, may stay on the list for a while. SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
Development

Successfully merging this pull request may close these issues.

9 participants