Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added breathability for mod materials #56099

Merged
merged 1 commit into from
Mar 16, 2022
Merged

added breathability for mod materials #56099

merged 1 commit into from
Mar 16, 2022

Conversation

bombasticSlacks
Copy link
Contributor

Summary

None

Purpose of change

Fixes #56020

Describe the solution

Added breathability,

Metals are 0 and default is 0 so I can ignore those.

Describe alternatives you've considered

Numbers could be up for debate.

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mods: Dark Skies Anything to do with Dark Skies Above, alien invasion mod with no zombies Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 14, 2022
@KorGgenT
Copy link
Member

i think maybe dragon hide and scales are swapped?

@bombasticSlacks
Copy link
Contributor Author

bombasticSlacks commented Mar 15, 2022 •
edited
Loading

Leathers are poor in general so I figured hide would be too. My thought with scales is they would be layered with gaps close to the skin in any armor so it would still leave some room for the material to breath.

It is your call though

Maleclypse
Maleclypse reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aftershock looks good.

@kevingranade kevingranade merged commit c5cf02e into CleverRaven:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse left review comments

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Mom-Bun Mom-Bun Awaiting requested review from Mom-Bun

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dark Skies Anything to do with Dark Skies Above, alien invasion mod with no zombies Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give Magiclysm's clothes and armors some breathability
4 participants
@bombasticSlacks @KorGgenT @Maleclypse @kevingranade