Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Magiclysm's clothes and armors some breathability #56020

Closed
Naadn opened this issue Mar 11, 2022 · 3 comments · Fixed by #56099
Closed

Give Magiclysm's clothes and armors some breathability #56020

Naadn opened this issue Mar 11, 2022 · 3 comments · Fixed by #56099
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding

Comments

@Naadn
Copy link
Contributor

Naadn commented Mar 11, 2022

Is your feature request related to a problem? Please describe.

After the sweating update, many vanilla material have breathability to determine their heat dissipation ability. But magiclysm's material haven't update yet so if someone wear its clothes and armors they will sweating non stop.

Solution you would like.

Add breathability value to magiclysm's materials like black_dragon_hide, black_dragon_scales, parabolan_wool and demon_chitin .

Describe alternatives you have considered.

don't

Additional context

Check other mods' material, they may haven't update the breathability too.

@NetSysFire NetSysFire added <Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Items: Armor / Clothing Armor and clothing labels Mar 11, 2022
@bombasticSlacks
Copy link
Contributor

really easy solution for this just need to add a single line to each material with a word from
"IMPERMEABLE,
POOR,
AVERAGE,
GOOD,
MOISTURE_WICKING,
SECOND_SKIN
" to each material

@Maleclypse
Copy link
Member

I’m adding Aftershock label as this probably needs to be done there too.

@Maleclypse Maleclypse added the Mods: Aftershock Anything to do with the Aftershock mod label Mar 14, 2022
@bombasticSlacks
Copy link
Contributor

The good news is mod developers really like adding metal and the default state is IMPERMEABLE.

I went to look at aftershock and just ended up doing the like 6 materials that need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants