Set the correct furniture id for box_large_reinforced #55256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-styled
It is inorrectly set to `f_cardboard_box_reinforced`, but it should be `f_cardboard_box_large_reinforced` ``` DEBUG : invalid furniture id "f_cardboard_box_reinforced" FUNCTION : const T &generic_factory<furn_t>::obj(const string_id<T> &) const [T = furn_t] FILE : src/generic_factory.h LINE : 445 VERSION : 0.F-5987-g0d23870736 ```
ccaviness
force-pushed
the
f_cardboard_box_large_reinforced
branch
from
c663a56 to
edc3a22
Compare
github-actions
bot
added
BasicBuildPassed
|
Agh, I'm a dummy. I even crafted one myself, I must have missed something somewhere, made a change and broke something. Thanks for beating me to it. |
Maleclypse
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Set the correct furniture id for box_large_reinforced"
Purpose of change
It is incorrectly set to
f_cardboard_box_reinforced, but it should bef_cardboard_box_large_reinforcedFixes this debug error that appears when viewing the recipe:
Describe the solution
Use correct furniture id.
Describe alternatives you've considered
Letting someone else fix it.
Testing
With this change, the error does not appear.