Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-layered cardboard box #55216

Merged

Conversation

anoobindisguise
Copy link
Contributor

Summary

Content "Upgrade to large cardboard box "

Purpose of change

Large Cardboard Box was a decent early game storage option but it was severely limited by its 50kg weight limit compared to its massive 300+L storage.

Describe the solution

Two rolls of duct tape and two large cardboard boxes = 2 layers thick cardboard box that can hold more weight.

Describe alternatives you've considered

Deleting my fork and recreating so that it stops showing the commits I pushed to master in my pull requests.

Testing

json only, appears to work fine

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 8, 2022
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 8, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit 9c5e55b into CleverRaven:master Feb 9, 2022
@ccaviness
Copy link
Contributor

Trying to view the recipe for the reinforced cardboard box triggers an error traceback:

 DEBUG    : invalid furniture id "f_cardboard_box_reinforced"

 FUNCTION : const T &generic_factory<furn_t>::obj(const string_id<T> &) const [T = furn_t]
 FILE     : src/generic_factory.h
 LINE     : 445
 VERSION  : 0.F-5987-g0d23870736

@ccaviness
Copy link
Contributor

#55256 fixes this.

@anoobindisguise anoobindisguise deleted the anoobindisguise-box branch October 14, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants