-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollbar to panel manager #54545
Conversation
Do you need to handle the case that a sidebar name wraps around (in which case number of items can be less than number of lines), or does it get truncated when getting too long to fit in the panel? |
If by that you mean making the window width dynamic to fit the text, then probably not. I can truncate the text with an ellipsis, sort of like how widgets handle it. Currently the text is cut-off if it's too long. |
The problem I was asking about was if the text was wrapped around when the description wouldn't fit, as that complicates the scrollbar handling. |
22818e8
to
7771c0d
Compare
7771c0d
to
7267bad
Compare
Works great! |
Summary
None
Purpose of change
Fixes #54532.
The list of widgets in the panel manager is getting long enough to overflow the available drawing space.
Describe the solution
Add a scrollbar to the panel list. This is complicated by 2 things:
2022-01-18.16-38-25.mp4
TODO:
Describe alternatives you've considered
Lengthening the panel manager window? The linked issue already explained why that's not a sustainable solution.
Testing
(See video above)
Additional context
I thought it would be easy just to slap on a scrollbar, turns out it's a bit more complex :P