Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom sidebar section list needs a scrollbar #54532

Closed
wapcaplet opened this issue Jan 18, 2022 · 1 comment · Fixed by #54545
Closed

Custom sidebar section list needs a scrollbar #54532

wapcaplet opened this issue Jan 18, 2022 · 1 comment · Fixed by #54545
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.

Comments

@wapcaplet
Copy link
Contributor

wapcaplet commented Jan 18, 2022

Is your feature request related to a problem? Please describe.

When using the "custom" sidebar with more than 22 available "widgets" defined (such as when Magiclysm is in use, and the Mana widgets are included), the list of sections goes outside the bounds of the popup.

Solution you would like.

There is a scrollbar function defined in src/output.cpp called draw_scrollbar (a shortcut to creating a scrollbar with the class scrollbar), which several other UIs make use of when lists are too long to fit.

Making the sidebar section list scrollable in the same way would be the ideal solution.

Describe alternatives you have considered.

Making the popup taller is not a sustainable solution, nor is removing or combining sections. I think a scrollbar is inevitable.

Additional context

image

@wapcaplet wapcaplet added <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 18, 2022
@LeahLuong
Copy link

You forgot to make the selling point this will make the Woadmap™ (#53957) that much more powerful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants