Fix eternal season affect on weather #54100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
astyled
Maleclypse
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
Fixes CleverRaven#26756. Use the same trick as I previously used for the sunlight angle in eternal season mode where it just repeats the same weather from the first game day. A twist here is that we still use the true timestamp for the simplex noise parameter, because otherwise the weather would be exactly the same from day to day.
jbytheway
force-pushed
the
eternal_season_temperatures
branch
from
aca0944 to
c532028
Compare
|
If you have a Ko-Fi or Paypal I'd like to toss a couple bucks your way. Been waiting a long time for this bugfix and I'm eternally grateful, pun very much intended. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Make eternal season option affect weather and water temperature"
Purpose of change
Fixes #26756.
Also fixes a similar bug related to seasonal water temperature.
Describe the solution
Use the same trick as I previously used for the sunlight angle in eternal season mode where it just repeats the same weather from the first game day. A twist here is that we still use the true timestamp for the simplex noise parameter, because otherwise the weather would be exactly the same from day to day.
Describe alternatives you've considered
Could take it more literally and match the start season rather than the start day, allowing for some additional variation. But it's not clear to me how to achieve that.
Testing
I added a new unit test to check this case.
Additional context