Fixed double material thickness for some armor defs #53881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombasticSlacks
changed the title
github-actions
bot
added
astyled
5 tasks
BrettDong
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixed doulbe material thickness for some armor defs"
Purpose of change
I noticed with #53871 that the values for the mantle seemed wrong. I looked into it and there was a bug with materials being added together for items that had multiple separate body part definitions instead of averaged.
This is used very few times in the code currently so I didn't notice it in the original PR it went in
Describe the solution
the values are now properly averaged instead of added.
Describe alternatives you've considered
Testing
Very few items use this specific type of entry.
Easiest item to test is the Thigh-high boots, in current experimental they have 6 bash, cut, ballistic
They are 2mm thick leather, they should have 4, 4, 4
with this change they have 4,4,4
Additional context