Implement inattentive trait: inability to see if creatures surrounding player sees player

[mkrutov]

Summary

Interface "add trait to hamper player's ability to judge creature's vision and intentions"

Purpose of change

I think that players being able to see if monsters sees them or not is quite powerful and after a brief discussion with players on discord awhile ago it was said that this would make a good challenge trait.

Describe the solution

If player chooses "Inattentive" trait during character creation, they loose the ability to see if monsters see them or not, as well as ability to judge critter's attitude/intent towards them.

Describe alternatives you've considered

n/a

Testing

Started a game, teleported to town, seen that monsters see me, debug-mutated the trait, seen that I don't know if monsters see me.

Additional context

There are two problems I don't really know from which side to tackle:
1) Tilesets - tilesets which support sees_you flag are a dead giveaway.
2) Hostility status. It seems that there is no easy way of changing only the UI, so I'd like to hear suggestions on this.

There are also two one minor problems I don't really know how to solve:
1) Trait name. Unattentive is OKish for non-english-native, but probably somebody would come up with a better name.
2) Trait cost. I don't really know if 2 points is a good spot, as on one hand it isn't all that limiting, on the other - many players, me included, rely on this information during raiding quite heavily.

[bombasticSlacks]

I'm pretty sure these need cleaned up too

[GoLoT]

Cataclysm-DDA/src/cata_tiles.cpp

Line 3464 in a2b3905

if( sees_player ) {

This needs to check for the trait too, to prevent drawing the visibility (!) marker on monsters.

[Terrorforge]

"Unattentive" isn't really a term that anyone uses. The word you are looking for is "Inattentive"

[mkrutov]

I've renamed it to inattentive, updated tiles bits and implemented Unknown status for shift+v menu(creature list). There is one problem with creature list and I'm unsure what exactly is causing this problem: see screenshot

.

[mkrutov]

Nevermind, I see what is causing it.. sigh.

[mkrutov]

LGTM analysis: C/C++ Failing after 72m — Analysis failed (could not build the base commit (579f907)) - unsure what do, this indicates some timeout in one of the tests.

[GoLoT]

LGTM analysis: C/C++ Failing after 72m — Analysis failed (could not build the base commit (579f907)) - unsure what do, this indicates some timeout in one of the tests.

It always times out, you can ignore that one.

[Zireael07]

I think you messed something up in the PR - unrelated commits showing up!

[mkrutov]

I think you messed something up in the PR - unrelated commits showing up!

I've rebased it to target latest master, indeed its weird that this commits show up.

[mqrause]

Not sure why this is missing the automated labels. You should probably rebase this to have it run the tests again. The labels would give it better visibility to get it merged.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.