Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scavenger Armor Overhaul #53533

Merged
merged 4 commits into from
Dec 19, 2021

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Dec 17, 2021

Summary

Content "Scavenger Gear has more of a niche"

Purpose of change

part of #53455 this part just updates Scavenger Gear

Describe the solution

Scavenger Gear is now:

  • Outer + Strapped
  • Has magazine pockets
  • Has a long holster pocket
  • Can hold Ablative Plates
  • Has different armor values on arms, legs, and torso (influenced by what its constructed from)

Recipe has been modified to require certain things that now have related pockets (XL holster, tacvest of some kind) and now requires layered kevlar in addition to a ballistic vest as the limbs of the jacket and pants are reinforced.

Describe alternatives you've considered

Not overhauling this stuff at all

Testing

image

Additional context

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 17, 2021
@catdach
Copy link
Contributor

catdach commented Dec 17, 2021

Is this going to conflict with a backpack sense it's on the "torso strapped" layer?

@bombasticSlacks
Copy link
Contributor Author

No you will still have the neck, hanging front and hanging back locations available on the torso for items. Backpacks are "hanging back"

@catdach
Copy link
Contributor

catdach commented Dec 17, 2021

Oh, sweet! Layer conflicts must have changed. The last time I checked anything without a "specifically" field would conflict with basically everything with a "specifically" field, good to hear that isn't the case anymore (if it ever was the case, I can't remember). Absolutely phenomenal work.

@bombasticSlacks
Copy link
Contributor Author

Torso is a bit of a special case. On the strapped layer it basically has an additional layer of sublocations in "hangs front", "hangs back" and "neck" those are assumed to always be off unless explicitly mentioned by the item.

@wapcaplet wapcaplet added Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON labels Dec 17, 2021
@Terrorforge
Copy link
Contributor

How do ablative plates interact with a garment that covers more than the torso? They're not gonna trigger if you get hit in the arm, are they?

@bombasticSlacks
Copy link
Contributor Author

ablative plates coverage and armor values are defined on the plates themselves so no they only will protect the torso.

If you wanted leg or arm plates you would need to define new plates with coverage of those places.

@bombasticSlacks
Copy link
Contributor Author

The heavy ballistic vest (which is already in game) covers the arms and legs with ablative plates already!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 18, 2021
@Maddremor
Copy link
Contributor

Could you reasonably cram a sheath for a knife in there somewhere? One should never be without a knife of some sort.

@bombasticSlacks
Copy link
Contributor Author

it is done, I thought a knife would fit in the deep holster but that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants