inventory_column: improve sorting #53373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Re-run of #53289
Items are sorted haphazardly in most windows based on
inventory_selector
(most notably in the pickup menu)Fixes: #52947
Describe the solution
Describe alternatives you've considered
order_by_parent()
: I'd have to understand it firstTesting
E
at menu) should be unaffectedAdditional context
before
after
edit: this screenshot still contains the bug with alphabetic sorting, but it should be fixed nowITEMS_WORN
is now a sortable category like the rest so it looks a little different in the player inventory window.