-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inventory_column: improve sorting #53289
Conversation
155e10e
to
c83b3d7
Compare
9a79cbf
to
ed9ac53
Compare
I've simplified the code a bit so it should loop less and be easier to understand. |
9b5caf8
to
76b7ca2
Compare
I've rebased away the bad commits and fixed alphabetic sorting so it actually works now and not just happens to be correct by accident. The situation with identically named items is still not perfect - their contents are not placed correctly when they are uncollapsed - |
76b7ca2
to
15740ce
Compare
15740ce
to
74ea471
Compare
properly sort entries alphabetically sort entries below their parents
Co-authored-by: jbytheway <[email protected]>
send it back whence it came
74ea471
to
7f49e82
Compare
why close? |
I don't want to push an incomplete solution and the two complete ones were rejected without suggestions for alternatives so I'm out of ideas. |
Summary
None
Purpose of change
Items are sorted haphazardly in most windows based on
inventory_selector
(most notably in the pickup menu)Fixes: #52947
Describe the solution
Describe alternatives you've considered
order_by_parent()
: I'd have to understand it firstTesting
E
at menu) should be unaffectedAdditional context
before
after
edit: this screenshot still contains the bug with alphabetic sorting, but it should be fixed nowI realize that this solution is quite ugly.not so ugly anymoreITEMS_WORN
is now a sortable category like the rest so it looks a little different in the player inventory window.