Change the weight allowance of clay pots.

[CosmicHitman]

Summary

Bugfixes "Slightly increased clay pot weight allowance so that they can store equal units of water and salt water"

Purpose of change

Bumping up the weight allowance slightly, so that both water and salt water can have 8 units stored in the pot. Salt water is 10 grams heavier, so it took up 1.82 kg instead of 1.75 kg at 7 units like water. This meant previously you could add an 8th unit of water (1.75 + 0.25 <= 2.00), but not salt water (1.82 + 0.26 > 2.00). Fixes #52824

Describe the solution

Weight limit was increased from 2000 g to 2100 g. Small enough increase that it can hold the 8th unit without being a huge increase.

Describe alternatives you've considered

• Make water solutions (sweet water, salt water, etc.) lighter. This contradicts real life though, so no.
• Make the weight limit 2750 g like the initial issue suggests. The clay pot is described as crude, so I imagine it is not as efficient as the large clay pot and would not have the same kg/L ratio. I also would personally prefer keeping the increase small to minimize side effects the change may have that I did not foresee.
• Leave it alone. It is not a huge deal in my opinion, but someone cared enough to make an issue. It is easy to fix anyway, so I may as well try.

Testing

Step 1: Create character and enter world.
Step 2: Debug in 2 clay pots.
Step 3: Fill one pot with water and see it hold 8 units.
Step 4: Fill the other part with salt water and see it hold 8 units.
Step 5: Ensure the inventory says it holds 2.1kg.

Additional context

Proof of clay pot holding 8 units of water.

Proof of clay pot holding 8 units of salt water.

Inventory screen showing the clay pot holds 2.1kg.

[Saicchi]

Nice one, but I just wanted to add.

The problem I have with that number are that it does not fix the problem (water gets 11 units, salt water gets 10).

This doesn't matter because clay pot maximum volume is still 2L, and water and salt water have the same volume per unit.

[CosmicHitman]

Right, I somehow forgot about that. I still prefer the lower number, but you are right that the problem I stated is not actually a problem.

[ashGlaw]

Looks good to me. Clever solution! Code does exactly what it says

[Photoloss]

Where does this value come from in the first place? It's described as a "crude" pot so "just make it strong enough" isn't valid, but where do we draw the line? Why should the pot be able to hold salt water but not maple syrup or honey? Is there any relevant use case where undershooting the weight tolerance is preferable to overshooting it? For example I would be very concerned with a wearable backpack being able to hold 200kg of weapons and armour but we don't have any mercury to carry around in pots nor any reason for wanting to do so.

[CosmicHitman]

• I agreed with the change because water and salt water are fairly similar materials, and being unable to put in a full unit because of a weight difference of 10 grams per unit at a small amount of units seemed strange.
• I chose 2100 because 8 units of salt water is 2080 g, and 2100 g is a round number just above it.
• Water (1.0 g/mL) and salt water (1.04 g/mL) are fairly different from honey (1.42 g/mL) or maple syrup (1.37 g/mL) in both density and composition, so I do not think an increase for those naturally follows this change.

[Photoloss]

Just because they don't exist in game doesn't mean we cannot realistically create a more and more concentrated solution of salt/sugar in water. I do not insist on any substance being included, I am asking why some of them are excluded and others aren't. The only relevant justification for a weight limit is the structural integrity of the pot so who says is isn't perfectly fine-tuned to just barely hold water? Are there any crafting recipes which technically require you to fill it with more total weight (no batches)?

Going through the drinks list I can see some of them are bullshit, but the densest one seems to be hot chocolate at 1.156 kg/l. Is there any particular reason why this pot should hold a full volume of salt water but not hot chocolate? If the limit is arbitrary why does it need to change at all?

[CosmicHitman]

Apparently you have given this much more thought than I have. The only thing I looked at is that the differences between water and salt/sweet/etc water are minuscule, yet a whole unit could not be added because it barely passed the weight limit. So I changed it with the idea that those two should be able to store an equal amount of units because of how similar they are. That is all. Past this point, I am just going to let the maintainers or whoever decide whether this change should be added or not.

[Saicchi]

Before arguing about the weight of these materials on a clay pot, check their volume per unit first to see if it would indeed fit ( which I didn't ).

This is just a simple QoL change since water, salt water and sugar water are so similar, and the weight limit raised is low enough.

[Photoloss]

Before arguing about the weight of these materials on a clay pot, check their volume per unit first to see if it would indeed fit

What exactly is stopping you from filling a crappy pot, or a plastic bag for that matter, to the brim with mercury IRL? The total weight overcomes the structural integrity of the material, causing it to rip or break under hydrostatic pressure. Is this mechanism relevant for a clay pot, and if yes where is the breaking point? So far no one has proposed an answer so I am only listing liquids a player would reasonably expect to fit into a kitchen utensil by their density, which allows calculating the respective limit directly from the pot volume.

The large pot cited in the linked issue can withstand liquids up to a density of 1.33 kg/l, narrowly excluding in-game maple syrup and molasses. Why would this smaller version be less sturdy when direct scaling would suggest the exact opposite? There are valid explanations, mainly having thinner walls, but none are obvious from the nature of the item.