Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase clay pot maximum contains weight #52824

Closed
Saicchi opened this issue Nov 14, 2021 · 0 comments · Fixed by #52842
Closed

Increase clay pot maximum contains weight #52824

Saicchi opened this issue Nov 14, 2021 · 0 comments · Fixed by #52842
Labels
Good First Issue This is a good first issue for a new contributor Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON

Comments

@Saicchi
Copy link
Contributor

Saicchi commented Nov 14, 2021

Is your feature request related to a problem? Please describe.

A clay jug holds 8 units of water but only 7 units of salt water. Though water and salt water have the same volume per unit, salt water is 10 grams heavier.

"id": "clay_pot",
"type": "GENERIC",
"category": "tools",
"name": { "str": "clay pot" },
"description": "A crude clay pot with lid used for cooking.",

"pocket_data": [ { "max_contains_volume": "2 L", "max_contains_weight": "2 kg", "watertight": true, "rigid": true } ],

Describe the solution you'd like

Clay pot to hold 8 units of salt water, that is increase its max_contains_weight.

Since its large counterpart can hold 37.5L of water or 50 kg. I suggest increasing it the clay_pot max_contains_weight to 2750 g.

Describe alternatives you've considered

Using another value.

Additional context

large clay pot ratio = 50 kg / 37.5 L = 1.33 kg/L. Multiply it by clay pot max_contains_weight and round it up to a multiple of 250 g and that is where I got the number from.

@wapcaplet wapcaplet added [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor Items: Containers Things that hold other things labels Nov 15, 2021
CosmicHitman pushed a commit to CosmicHitman/Cataclysm-DDA that referenced this issue Nov 15, 2021
By bumping up the weight allowance slightly, both water and salt water
can have 8 units stored in the pot. Before, they could not.
fixes CleverRaven#52824
kevingranade pushed a commit that referenced this issue Nov 17, 2021
By bumping up the weight allowance slightly, both water and salt water
can have 8 units stored in the pot. Before, they could not.
fixes #52824

Co-authored-by: CosmicHitman <N/A>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants