Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Change riot and swat armour to represent the armour plates, not the armour plates plus the uniform underneath."
Purpose of change
Riot armour is too good. It's great armour IRL, but it does not offer equal and complete protection on all areas.
Notably the stomach, arms, and legs all have large gaps in protection covered by a thick, durable, flexible cloth layer that is definitely great but should not repel bullets and terrible slashing claws. For game balance reasons, as well, this armour is readily available from the start of the game and needs to have drawbacks. It should, however, remain a very good option in the early game. It just needs its real drawbacks added in.
Describe the solution
Change riot and swat armour stats to represent only the armour plates. Whatever you are wearing below can still protect your squishy bits, but there are clear gaps in the armour that need to be represented.
Adjust the components of riot armour a little: the outer layer is now made of tougher polycarbonate, not just generic plastic.
Riot armour now offers somewhat better protection, but much less complete.
SWAT armour is significantly worse, but also less encumbering. Debatably it's unclear if SWAT armour should even exist as an independent item, or if SWAT zombies should be wearing soldier gear. I don't really care what solution we land on, as long as SWAT armour stops giving 95% protection from almost all damage while being lootable from a zombie.
Went through and audited spawns of these items, resulting in some adjustments to how zombie armour spawns (especially swat zombies which were pretty much guaranteed to always spawn fully equipped).
Describe alternatives you've considered
Initially I was going to move these plated armours to the "strapped" layer instead of "outer". This may still be the right course of action in the future, as large armour plates should interfere with backpacks and tool belts and things, but to avoid some really weird layering it's gonna need to be all in one go.
There's a decent argument to remove the arm/leg coverage of both of these armours altogether and have that role be played by armguard_hard, legguard_hard, a riot armour torso piece. I did not do that here, because (1) it's a lot of work and (2) this still lets me have a special sprite for riot armour, which is good.
There's also an argument to just make swat armour a direct copy of an esapi or other bulletproof vest with some pockets and extra encumbrance. If anyone knows more about american SWAT they're welcome to have at 'er
Testing
Seems to work.
Additional context
I'm coming for you, ESAPI vest.