Fix deflated off-road bicycle wheel recipe, plus set correct length and volume for wheel rims (#51264) #51292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
Actually, in each case I used the largest potential dimensions for each rim. So the bicycle wheel I calculated IS an off-road size of 30mm width. |
ghost
marked this pull request as ready for review
|
I don't know what happened here with the github infrastructure, can you just rebase this and push to see if we can get the tests running? |
|
@kevingranade No problem, should have been rebased and pushed as requested |
|
Closed due to resubmission |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix deflated off-road bicycle tire recipe, plus set correct length and volume for tire rims"
Purpose of change
Fixes #51264
Describe the solution
Change deflated off-road bicycle wheel recipe to use correct rim
Change longest side and volume of wheel rims as follows (With thanks to @RandDenner for the calculations here):
Bicycle rim (27", 30mm wide) - 686mm, 11L
motorcycle (20", 60mm wide) - 508mm, 12L
medium steel (17", 190mm wide) - 432mm, 28L
wide steel (24", 240mm wide) - 610mm, 70L
Modified the volumes of deflated and inflated versions of tires based on these rims to line up
Describe alternatives you've considered
Suggestion by @actual-nh to create a wider rim for off-road bicycle wheels, will look at that in a future PR as well as current wheel volume
Testing
Loaded into base game and tested
Additional context