Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off road bicycle wheels made using incorrect rims? #51264

Closed
RandDenner opened this issue Aug 31, 2021 · 6 comments · Fixed by #51798
Closed

Off road bicycle wheels made using incorrect rims? #51264

RandDenner opened this issue Aug 31, 2021 · 6 comments · Fixed by #51798
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions

Comments

@RandDenner
Copy link
Contributor

RandDenner commented Aug 31, 2021

Describe the bug

The 27" off-road bicycle wheels are using the wide steel rim that wide vehicle wheels are also using, and not the bicycle rim.

Steps To Reproduce

Just spawn them and look at the item info panel.

Expected behavior

That bicycles don't use huge car tire rims.

Screenshots

Wide steel rim and bicycle rim:
image

Versions and configuration

Win10 64, experimental tiles 2021-08-31-920 (0447a46), no mods

@RandDenner
Copy link
Contributor Author

Ping: @occulti, this is your PR. Was this intended?

@RandDenner
Copy link
Contributor Author

RandDenner commented Aug 31, 2021

Oh, also the lengths are too small. All are 254mm, which is 10 inches.
17" is 432mm, 20" is 508mm, 24" is 610mm, 27" is 686mm
image

@RandDenner
Copy link
Contributor Author

RandDenner commented Aug 31, 2021

Also, volume is off.
Using the formula for a cylinder and a spreadsheet, I find that the volumes are pretty low, too.
Bicycle rim (27", 30mm wide) = 11L, motorcycle (20", 60mm wide) = 12L, medium steel (17", 190mm wide) = 28L, wide steel (24", 240mm wide) = 70L. (That 70L isn't a typo. Those are huge.)

@actual-nh actual-nh added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact Vehicles Vehicles, parts, mechanics & interactions labels Aug 31, 2021
@actual-nh
Copy link
Contributor

Sounds like the motorcycle would be a better bet for matching, if off-road bike wheels are indeed wider in the rim (IIRC, they are).

@ghost
Copy link

ghost commented Sep 1, 2021

@RandDenner Not intentional but an oversight - the intention was for off-road bicycle wheels to use the bicycle rim but I must have copy-pasted and not changed.

Thank you for the calculations too - the originals were just best guesses based on the dimensions and volume of the wheels themselves but these are much more accurate, will look to adjust now.

@RandDenner
Copy link
Contributor Author

Sounds like the motorcycle would be a better bet for matching, if off-road bike wheels are indeed wider in the rim (IIRC, they are).

Not so much wider that bicycle rims don't still basically make sense.
narrower ones use around 20 mm, wider ones are about 30mm, which I used for calculations.
Both are a lot narrower than motorcycle rims, but also a greater diameter (27" as opposed to motorcycle 20").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
2 participants