Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Lab security drones & eoc #50920

Merged
merged 2 commits into from
Aug 21, 2021

Conversation

curstwist
Copy link
Contributor

Summary

none

Purpose of change

Someone on reddit reported getting the EOC related events from the Lab security drones while in a city. I talked to Ramza13 and redid my lab drones to hopefully fix this issue.

Describe the solution

  1. Removed the global re-occurances from all EOC entries.
  2. Changed the spell "effect" from mutation to "effect_on_condition" and redid all EOC to follow the example in: Create talker monster, add ability for spells to use dialog effects/conditions #49986
  3. Removed mutation entries

NOTE: I may need migration help for this? I'm not sure but I'm worried about breaking saves due to these mutations being added to player's current games due to global re-occurrences.

Describe alternatives you've considered

Testing

In game testing. These are exhibiting all their old behaviors again without using a mutation/trait to track their badge status.

Additional context

relevant reddit post

@curstwist curstwist added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly. labels Aug 20, 2021
Copy link
Contributor

@Ramza13 Ramza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use my suggestions make sure to lint+run it quick, I might have misplaced a { or two.

data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
data/json/monsters/lab_security_drones.json Outdated Show resolved Hide resolved
@curstwist
Copy link
Contributor Author

If you use my suggestions make sure to lint+run it quick, I might have misplaced a { or two.

Incorporated and tested in game. Thanks for your help making these more concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants