Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Pseudovamp Temp Workaround #49479

Closed
wants to merge 3 commits into from

Conversation

Xpyder
Copy link
Contributor

@Xpyder Xpyder commented Jun 27, 2021

Summary

SUMMARY: Bugfixes "Pseudovamp Workaround"

Purpose of change

Pseudovamp is currently broken because blood power generator is broken

Describe the solution

Temporarily replace with metabolic interchange and cannibal
Add comments so future editors know to swap it back when/if it gets fixed

Describe alternatives you've considered

Fixing it, but I've tried and after 3 days it's still not working

Testing

Minor change, created test character and seems to work

Additional context

Related #49478
Related #49352

May show as conflicting with #49352 but the fundamental change is the same: removing the bionic from this profession. This change just replaces it instead of leaving a hole

@Xpyder Xpyder requested a review from KorGgenT as a code owner June 27, 2021 20:08
@Xpyder
Copy link
Contributor Author

Xpyder commented Jun 27, 2021

PR validator still confuses me. I've tried as the template says (Category Bugfixes) and as the regex seems to say (### Summary \n SUMMARY: Bugfixes) but it's still mad at me so ¯\_(ツ)_/¯

Added HUNGER to balance Cannibal (stacks with the calorie consumption from metabolic interchange and nanobots)
@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) Bionics CBM (Compact Bionic Modules) Mods: Magiclysm Anything to do with the Magiclysm mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies (P2 - High) High priority (for ex. important bugfixes) labels Jun 28, 2021
@actual-nh actual-nh removed the (P2 - High) High priority (for ex. important bugfixes) label Jun 29, 2021
@Xpyder Xpyder deleted the Pseudo-Vamp-Workaround branch July 1, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) Mods: Magiclysm Anything to do with the Magiclysm mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants