Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Fix Duplicated tainted blood and temporarily remove blood generator from the game #49352

Closed
wants to merge 3 commits into from

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Jun 18, 2021

Summary

Mods "Fix Duplicated tainted blood and temporarily remove blood generator from the game"

Purpose of change

  • Magiclysm has a different id for tainted blood: tainted_blood instead of blood_tainted in vanilla
  • Blood generator can't use blood and tainted blood because they are commestible, which creates a lot of confusion from players

Describe the solution

  • Add a migration entry to convert tainted_blood into blood_tainted
  • Oblsote tainted_blood
  • Temporarily remove blood generator from spawning untill Move refueling CBM to its own menu #48750 is a thing and comestibles can also be used as fuel

Describe alternatives you've considered

use copy-from and delete to make tainted blood not comestible in magclysm but I didn't manage to make it work

Testing

Load a save with tainted_blood in it
No errors
Only blood_tainted is available

Re try with tainted_blood in a flask
get error about item not fitting into pocket
Get flask of none

Load save with already a blodd generator installed
It's still as confusing as before and can't use blood or tainted blood

Additional context

@Fris0uman Fris0uman requested a review from KorGgenT as a code owner June 18, 2021 10:29
@Fris0uman Fris0uman changed the title [Magiclysm] Fix Duplicated tainted blood and temporarily blood generator from the game [Magiclysm] Fix Duplicated tainted blood and temporarily remove blood generator from the game Jun 18, 2021
@Fris0uman Fris0uman marked this pull request as draft June 18, 2021 11:04
@Fris0uman Fris0uman marked this pull request as ready for review June 18, 2021 12:13
@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) Bionics CBM (Compact Bionic Modules) Items: Food / Vitamins Comestibles and drinks Mods: Magiclysm Anything to do with the Magiclysm mod labels Jun 18, 2021
Xpyder added a commit to Xpyder/Cataclysm-DDA that referenced this pull request Jun 27, 2021
@Fris0uman Fris0uman deleted the duplicated_blood branch July 4, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants