Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charges_per_use to powered_earmuffs_on #48278

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

Zeropol
Copy link
Contributor

@Zeropol Zeropol commented Mar 30, 2021

Summary

Bugfixes "Add charges_per_use to powered_earmuffs_on"

Purpose of change

Quick fix #48261
The shooter's earmuff item was deleted on activation.

Describe the solution

Add charges_per_use to powered_earmuffs_on, so powered_earmuffs use this on activation.
See #47887
See #47870

Describe alternatives you've considered

It don't fixe the underlying problem but at least the shooter's earmuffs won't delete on activation.
I'm not skilled enough to fixe the problem.

Testing

Spawned powered_earmuffs and battery, activated / deactivated.

Additional context

If this is irrelevant because the only thing to do would be to correct the underlying problem, please tell me.

Powered_earmuff consumme the charges in powered_earmuffs_on on activation.

Quick fix CleverRaven#48261
See CleverRaven#47887
See CleverRaven#47870
@BrettDong BrettDong added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Mar 30, 2021
@toweroglass
Copy link

hopefully the underlying problem get's sorted. I had the same issue with the CRIT Helmet yesterday. A day after my earmuffs disappeared. Not sure how many other items this could effect.

@ZhilkinSerg ZhilkinSerg merged commit 93a65a5 into CleverRaven:master Mar 31, 2021
@Zeropol Zeropol deleted the fixe-shooter-earmufs branch March 31, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shooter's earmuffs activation deletes the item
4 participants