Fix temperature calculations for items carried by player #46897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix temperature for items carried by player"
Purpose of change
Fixes: #46880
Fixes: #34316
It turns out that temperature was completely broken for items that were carried by player. Somehow nobody noticed it other than when interacting with freezers.
Describe the solution
There was a bool in the function call. That bool was not supposed to be there.
The bool "false" was used as the insulation "0".
Insulation 0 led to infinite thermal conductivity.
So items carried by player would always get set to enviroment temperature every time they were processed.
Describe alternatives you've considered
Testing
Take item that is clearly at very different temperature from envirmoent (frozen), put it in player inventory, wait 10 minutes.
The item gets warmer but does not instantly become enviroment temperature when it gets processed.
Additional context