Faster tool selection dialog with lots of items nearby #46778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
[C++]
|
@mqrause: thank you a lot for caring for the issue I reported in such an amazingly quick manner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Faster tool selection dialog with lots of items nearby"
Purpose of change
Fixes #46772
Describe the solution
Moved a condition so it (usually) doesn't alternate between different calls of
Character::crafting_inventorywhich invalidate the crafting inventory cache.Describe alternatives you've considered
Wanted to move those calls out of the loop first, but that won't work with the cache and references, I guess.
Testing
See issue.