Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused feather flag #46045

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Dec 14, 2020

Summary

SUMMARY: Features "Delete unused feather flag"

Purpose of change

The JSON's FEATHER flag does nothing useful and this is not used anywhere.

Describe the solution

Delete this flag at all.

Describe alternatives you've considered

I tried to slightly increase the game realism and make implementation of the FEATHER flag in #45995. But I had to close this PR.

Testing

The game compiled without errors.

Additional context

@BrettDong BrettDong added the [JSON] Changes (can be) made in JSON label Dec 14, 2020
@Fris0uman
Copy link
Contributor

are feathers actually in an harvest entry now or are they just not availble?

@8street
Copy link
Contributor Author

8street commented Dec 14, 2020

Feathers, as an object, are present in harvest entry. Hereinafter.

{ "drop": "feather", "type": "skin", "mass_ratio": 0.01 }

@ZhilkinSerg ZhilkinSerg merged commit abf2fc3 into CleverRaven:master Dec 14, 2020
@8street 8street deleted the delete_unused_feather_flag branch December 15, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants