Add feather flag implementation #45995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
[C++]
Co-authored-by: Anton Burmistrov <[email protected]>
|
I'd rather go with deleting the flag, this kind of thing is handled by the harvest entries now. |
|
Ok. I'll create new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Add feather flag implementation"
Purpose of change
As mentioned in #45961 JSON's FEATHER flag is deprecated and doesn't do anything.
Describe the solution
Monsters with FEATHER flag can now occasionally lose feathers when moving and when attacked.
Describe alternatives you've considered
Delete this flag at all.
Testing
Spawning birds with this flag and attack them. Also see how them running away and lose feathers.
Additional context