Incorporate exertion penalty into counter cost check #45523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #45064
The check to prevent counter-lock did not incorporate weariness, so when weary it does not prevent counter-lock.
Describe the solution
Factor in weariness penalty when determining if a counter would lead to counter-lock.
Describe alternatives you've considered
Ideally this would be inlined in attack_speed(), but I'm wary of side effects right now.
Testing
Make a character that can reliably trigger counters.
Get really weary.
Confirm that even while being attacked, the character can still act every turn. (might not be able to move on consecutive turns if weary cost makes movement really slow?)