Jsonify parking lot #44933
Merged
Jsonify parking lot #44933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and mention that it won't use built-in mapgen function
Night-Pryanik
added
[JSON]
|
Hey, I forgot about savegame migration:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Jsonify parking lot."
Purpose of change
Continuation of hardcode-to-json project.
Describe the solution
Added json mapgen variant which is almost identical to previous hardcoded variant. Created a
city_buildingovermap special definition for it. Removed directive to use built-in hardcoded function in overmap terrain. Removed all mentions of hardcoded function from .cpp and .h files.Describe alternatives you've considered
None
Testing
Debug-spawned separate parking lot location. Debug-spawned mine entrance location. Naturally found parking lot in cities. Checked if all is ok in all cases.
Additional context
None.