Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proficiencies for weapons - piercing.json and bashing.json #44552

Merged
merged 7 commits into from
Oct 5, 2020

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Oct 1, 2020

Summary

SUMMARY: Content "Proficiencies for weapons - piercing.json and bashing.json"

Purpose of change

Continuing project to implement proficiencies consistently across recipes.

Describe the solution

Adds proficiencies to bashing.json and piercing.json in the weapons folders. I believe this is all the proficiencies those files are going to need, which is cool.

Describe alternatives you've considered

I could have added bladesmithing requirements to the bronze weaponry, but that creates a complex dependency tree because bladesmithing requires blacksmithing but bronze weapons don't. Instead I just put a bit more weight on redsmithing.

Testing

loads. Simple changes, minimal testing done.

Additional context

Dependent on #44446

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Oct 1, 2020
@Rail-Runner
Copy link
Contributor

I could have added bladesmithing requirements to the bronze weaponry, but that creates a complex dependency tree because bladesmithing requires blacksmithing but bronze weapons don't. Instead I just put a bit more weight on redsmithing.

Maybe it's worth adding "bronze bladesmithing" proficiency for use in those recipes, then? So you still need bladesmithing knowledge, but it's different than what you'd need for steel blades.

@I-am-Erk
Copy link
Member Author

I-am-Erk commented Oct 3, 2020

There aren't really enough bronze weapons to merit it.

@I-am-Erk I-am-Erk marked this pull request as ready for review October 4, 2020 19:15
@I-am-Erk I-am-Erk merged commit 83721c4 into CleverRaven:master Oct 5, 2020
@I-am-Erk I-am-Erk deleted the proficiency-8 branch October 5, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants